Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecr DSB ORNX #452

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Forecr DSB ORNX #452

merged 1 commit into from
Dec 23, 2024

Conversation

asuykov
Copy link
Contributor

@asuykov asuykov commented Dec 17, 2024

Contracts for the machine configurations in balena-jetson-orin PR #532.

Copy link
Contributor

flowzone-app bot commented Dec 17, 2024

A repository maintainer needs to approve this workflow run.

https://github.com/balena-io/contracts/actions/runs/12372195409

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

"version": "1",
"type": "hw.device-type",
"aliases": [],
"name": "Forecr",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asuykov , let's rename this to some thing more descriptive, like for example "Forecr DSB ORNX Nano 8GB"

@@ -0,0 +1,39 @@
{
Copy link
Contributor

@acostach acostach Dec 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we can drop this contract entirely, as the module currently used is Nano 8GB and we will keep that one only

@@ -0,0 +1,39 @@
{
"slug": "forecr-dsb-ornx-orin-nx-16gb",
"version": "1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we can drop this file entirely, as the module currently used is Nano 8GB

@acostach
Copy link
Contributor

acostach commented Dec 21, 2024

@asuykov let's use the Orin Nano icon for the Nano 8GB device-type, unless you have a Forecr icon already. The Nano 4GB and NX 16GB contracts can be dropped for now.

Also, please add a Change-type: patch line to the commit message, right above Signed-off-by:...

Copy link
Contributor

flowzone-app bot commented Dec 23, 2024

A repository maintainer needs to approve this workflow run.

https://github.com/balena-io/contracts/actions/runs/12464808346

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@acostach
Copy link
Contributor

acostach commented Dec 23, 2024

@asuykov could you please rebase this branch on top of master?

git checkout master
git pull origin master
# Use git log to ensure all changes have been pulled in the master branch and they reflect what's in github
git checkout forecr
git rebase master
git push origin forecr --force

@asuykov asuykov force-pushed the forecr branch 2 times, most recently from 63c8160 to aaacf7d Compare December 23, 2024 10:50
Change-type: patch
Signed-off-by: Alex Suykov <[email protected]>
Copy link
Contributor

flowzone-app bot commented Dec 23, 2024

A repository maintainer needs to approve this workflow run.

https://github.com/balena-io/contracts/actions/runs/12465603513

Maintainers, please review all commits and react with 👍 to approve or 👎 to reject.

Things to look for: GitHub Actions Security Cheat Sheet

@acostach acostach enabled auto-merge December 23, 2024 10:54
@acostach acostach merged commit f9f2fff into balena-io:master Dec 23, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants